| To: | Ralf Baechle <ralf@linux-mips.org> |
|---|---|
| Subject: | Re: [PATCH] MIPS getdomainname() off by 1; |
| From: | Geert Uytterhoeven <geert@linux-m68k.org> |
| Date: | Thu, 8 Jul 2004 10:46:19 +0200 (MEST) |
| Cc: | "Randy.Dunlap" <rddunlap@osdl.org>, Linux/MIPS Development <linux-mips@linux-mips.org> |
| In-reply-to: | <20040708004951.GA17045@linux-mips.org> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <20040531202101.4ace5e95.rddunlap@osdl.org> <20040708004951.GA17045@linux-mips.org> |
| Sender: | linux-mips-bounce@linux-mips.org |
On Thu, 8 Jul 2004, Ralf Baechle wrote:
> On Mon, May 31, 2004 at 08:21:01PM -0700, Randy.Dunlap wrote:
> > irix_getdomainname() max size appears to be off by 1;
> > other similar code in kernel uses __NEW_UTS_LEN as the max size,
> > and <domainname> includes an extra byte for the terminating
> > null character.
> >
> > Does sysirix.c need to limit <len> to 63 instead of 64 for some
> > reason?
>
> I would know why - and it has other bugs also, so I removed it by the
> normal Linux getdomainname(2) for SysV flavour syscalls, too.
I saw you even removed it from 2.0. Woow! ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Optimisation, Sridhar Adagada |
|---|---|
| Next by Date: | Re: Optimisation, Geert Uytterhoeven |
| Previous by Thread: | Re: [PATCH] MIPS getdomainname() off by 1;, Ralf Baechle |
| Next by Thread: | Re: [PATCH] MIPS getdomainname() off by 1;, Ralf Baechle |
| Indexes: | [Date] [Thread] [Top] [All Lists] |