linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS getdomainname() off by 1;

To: "Randy.Dunlap" <rddunlap@osdl.org>
Subject: Re: [PATCH] MIPS getdomainname() off by 1;
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 8 Jul 2004 02:49:51 +0200
Cc: linux-mips@linux-mips.org
In-reply-to: <20040531202101.4ace5e95.rddunlap@osdl.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20040531202101.4ace5e95.rddunlap@osdl.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.1i
On Mon, May 31, 2004 at 08:21:01PM -0700, Randy.Dunlap wrote:

> irix_getdomainname() max size appears to be off by 1;
> other similar code in kernel uses __NEW_UTS_LEN as the max size,
> and <domainname> includes an extra byte for the terminating
> null character.
> 
> Does sysirix.c need to limit <len> to 63 instead of 64 for some
> reason?

I would know why - and it has other bugs also, so I removed it by the
normal Linux getdomainname(2) for SysV flavour syscalls, too.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>