linux-mips
[Top] [All Lists]

Re: 2.4 pci_dma_sync_sg fix

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: 2.4 pci_dma_sync_sg fix
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 1 Jul 2004 15:59:19 +0200
Cc: linux-mips@linux-mips.org
In-reply-to: <20040701.224535.71082878.anemo@mba.ocn.ne.jp>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20040701.222120.41626500.anemo@mba.ocn.ne.jp> <20040701132240.GA6219@linux-mips.org> <20040701.224535.71082878.anemo@mba.ocn.ne.jp>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.1i
On Thu, Jul 01, 2004 at 10:45:35PM +0900, Atsushi Nemoto wrote:

> >>>>> On Thu, 1 Jul 2004 15:22:40 +0200, Ralf Baechle <ralf@linux-mips.org> 
> >>>>> said:
> 
> ralf> Leave the #ifdef stuff there - or otherwise gcc might optimize
> ralf> this into empty loops ...
> 
> The loop contains paranoid out_of_line_bug, so it never be optimized
> to empty.

Indeed and I think that's a bit of overkill.  I've never seen these
assertions catch any bugs - and 2.4 isn't exactly new anymore.  Anyway,
even if the loop was empty gcc would not eleminate it.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>