linux-mips
[Top] [All Lists]

Re: [patch] Incorrect mapping of serial ports to lines

To: Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [patch] Incorrect mapping of serial ports to lines
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Wed, 30 Jun 2004 14:10:43 +0200 (CEST)
Cc: Jun Sun <jsun@mvista.com>, Ralf Baechle <ralf@linux-mips.org>, Linux/MIPS Development <linux-mips@linux-mips.org>
In-reply-to: <Pine.GSO.4.58.0406301006340.20130@waterleaf.sonytel.be>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <Pine.LNX.4.55.0406281513120.23162@jurand.ds.pg.gda.pl> <20040628235908.GC5736@linux-mips.org> <Pine.LNX.4.55.0406291345590.31801@jurand.ds.pg.gda.pl> <Pine.GSO.4.58.0406291408020.29058@waterleaf.sonytel.be> <Pine.LNX.4.55.0406291546480.31801@jurand.ds.pg.gda.pl> <20040629151313.E6498@mvista.com> <Pine.LNX.4.55.0406300022290.31801@jurand.ds.pg.gda.pl> <Pine.GSO.4.58.0406301006340.20130@waterleaf.sonytel.be>
Sender: linux-mips-bounce@linux-mips.org
On Wed, 30 Jun 2004, Geert Uytterhoeven wrote:

> > > (maybe a little dramatic) is to remove all static serial port definition
> > > and push them into board setup routine.  asm/serial.h only needs
> >
> >  I'm not sure that is the right way of doing it -- note that one problem
> > is serial drivers can be built as modules and inserted at the run time.
> 
> The same is true for whatever other type of device (SCSI, IDE, Ethernet, ...).

 Yes and sensible drivers handle it correctly.  A classical example is the 
8390.c Ethernet driver with its various frontends.

> And depending on the order of module loading, the order of the devices will
> change.

 And given the order is fully configurable, it's actually a good thing.

  Maciej

<Prev in Thread] Current Thread [Next in Thread>