linux-mips
[Top] [All Lists]

Re: [patch] Incorrect mapping of serial ports to lines

To: Jun Sun <jsun@mvista.com>
Subject: Re: [patch] Incorrect mapping of serial ports to lines
From: Ralf Baechle <ralf@linux-mips.org>
Date: Wed, 30 Jun 2004 00:49:32 +0200
Cc: "Maciej W. Rozycki" <macro@linux-mips.org>, Geert Uytterhoeven <geert@linux-m68k.org>, Linux/MIPS Development <linux-mips@linux-mips.org>
In-reply-to: <20040629151313.E6498@mvista.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <Pine.LNX.4.55.0406281513120.23162@jurand.ds.pg.gda.pl> <20040628235908.GC5736@linux-mips.org> <Pine.LNX.4.55.0406291345590.31801@jurand.ds.pg.gda.pl> <Pine.GSO.4.58.0406291408020.29058@waterleaf.sonytel.be> <Pine.LNX.4.55.0406291546480.31801@jurand.ds.pg.gda.pl> <20040629151313.E6498@mvista.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.1i
On Tue, Jun 29, 2004 at 03:13:13PM -0700, Jun Sun wrote:

> > > The NEC DDB Vrc-5074 (and probably the other DDB variants as well) has one
> > > serial port in the Nile 4 host bridge, and 2 serial ports in the Super 
> > > I/O.
> > > 
> > > To me it sounds the most logical if the one in the Nile 4 is ttyS0.
> > 
> >  Then we need to find a way to make the order configurable somehow.
> 
> This is why I favor run-time serial port configuration.  My view
> (maybe a little dramatic) is to remove all static serial port definition
> and push them into board setup routine.  asm/serial.h only needs
> to define the number serial lines, which itself could be configurable.

<asm/serial.h> is on it's way out of the kernel - it's only a question of
time until either the current maintainer of the serial driver or somebody
with more time at hands will eleminate it.  And serial.h was always only
meant to handle the kind of serial interfaces of which you just have to
know that they're there because probing for it isn't possible.  Something
which these days is getting increasingly more rare thanks to PCI.

What I really wouldn't like to see is the runtime registration for all
the legacy serial stuff that possibly could be plugged into some board
be duplicated into half a dozen of systems ...

  Ralf

<Prev in Thread] Current Thread [Next in Thread>