linux-mips
[Top] [All Lists]

Re: [PATCH] make ps2 mouse work ...

To: Jun Sun <jsun@mvista.com>
Subject: Re: [PATCH] make ps2 mouse work ...
From: Vojtech Pavlik <vojtech@suse.cz>
Date: Wed, 16 Jun 2004 19:58:11 +0200
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org
In-reply-to: <20040616100446.J28403@mvista.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20040615191023.G28403@mvista.com> <20040615205611.1e9cbfcc.akpm@osdl.org> <20040616121149.GA9325@ucw.cz> <20040616100446.J28403@mvista.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.1i
On Wed, Jun 16, 2004 at 10:04:46AM -0700, Jun Sun wrote:
> On Wed, Jun 16, 2004 at 02:11:49PM +0200, Vojtech Pavlik wrote:
> > On Tue, Jun 15, 2004 at 08:56:11PM -0700, Andrew Morton wrote:
> > 
> > > > I found this problem on a MIPS machine.  The problem is 
> > > > likely to happen on other register-rich RISC arches too.
> > > > 
> > > > cmdcnt needs to be volatile since it is modified by
> > > > irq routine and read by normal process context.
> > > 
> > > volatile is not the preferred way to fix this up.  This points at either a
> > > locking error in the psmouse driver or a missing "memory" thingy in the
> > > mips port somewhere.
> > > 
> > > Please describe the bug which led to this patch.  Where was it getting 
> > > stuck?
> > 
> > My current BK tree has this fixed using atomic bitfields, which do
> > compilation and memory barriers. I plan to sync it to Linus post 2.6.7.
> > 
> 
> Can you post the patch here?  I am sure many people are eagerly waiting
> for the right fix.  Plus there will be extra pairs of eyes to exam the fix.

Sure. Here it is.

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR

Attachment: psmouse-bits
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>