linux-mips
[Top] [All Lists]

Re: [PATCH] gcc 3.4 drops "accum" clobber, replace with "hi" intime.c

To: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Subject: Re: [PATCH] gcc 3.4 drops "accum" clobber, replace with "hi" intime.c
From: Ralf Baechle <ralf@linux-mips.org>
Date: Sun, 18 Apr 2004 15:00:30 +0200
Cc: "Bradley D. LaRonde" <brad@laronde.org>, linux-mips@linux-mips.org, Eric Christopher <echristo@redhat.com>, Daniel Jacobowitz <dan@debian.org>
In-reply-to: <Pine.LNX.4.55.0404131451200.15949@jurand.ds.pg.gda.pl>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <Pine.GSO.4.10.10404122244110.8735-100000@helios.et.put.poznan.pl> <20040412231309.GA702@linux-mips.org> <03f301c420e7$d8de2d70$8d01010a@prefect> <048e01c420f1$ad4ae3b0$8d01010a@prefect> <1081818125.19719.14.camel@dzur.sfbay.redhat.com> <04d501c420f3$6c836a30$8d01010a@prefect> <20040413010732.GA7560@nevyn.them.org> <04f501c420f4$5563f620$8d01010a@prefect> <053c01c420f5$ec230190$8d01010a@prefect> <Pine.LNX.4.55.0404131451200.15949@jurand.ds.pg.gda.pl>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.1i
On Tue, Apr 13, 2004 at 02:57:07PM +0200, Maciej W. Rozycki wrote:

> 
> > OK, so this patch actually builds, and it sounds like it will do the job,
> > since "accum" means "hi and low", "lo" is already clobbered in all cases,
> > and either "hi" is the output and doesn't need clobbering (hunks 1, 2, and
> > 4), or "hi" is already clobbered (hunk 3).
> 
>  There are more places this should be dealt with and I have the following 
> preliminary patch for this, but I'm unsure about removal of "accum" being 
> completely safe for older compilers.

From everything I know about the behavior of older compilers this should
be save.  "accum" was treated a little strage in some context anyway, so
I'm happy to see it go ...

  Ralf

<Prev in Thread] Current Thread [Next in Thread>