linux-mips
[Top] [All Lists]

BUG in pcnet32.c?

To: linux-mips@linux-mips.org
Subject: BUG in pcnet32.c?
From: Brian Murphy <brian@murphy.dk>
Date: Mon, 29 Mar 2004 22:01:35 +0200
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030714 Debian/1.4-2
In pcnet32.c where the driver writer sets up her receive buffers there is this line

lp->rx_dma_addr[i] = pci_map_single(lp->pci_dev, rx_skbuff->tail, rx_skbuff->len, PCI_DMA_FROMDEVICE);

the length value turns out to be 0 and crashes the running process,ifconfig.
Is making a map for a buffer of length 0 valid at all? If not what the hell is going on here.

I feel this should say PKT_BUF_SZ instead of rx_skbuff->len which is the length of skbuff which has been
allocated at this point in the code, this is line 986 in todays checkout.

Something is wrong in any case, any pointers?

/Brian


<Prev in Thread] Current Thread [Next in Thread>