| To: | Jun Sun <jsun@mvista.com> |
|---|---|
| Subject: | Re: [patch] Prevent dead code/data removal with gcc 3.4 |
| From: | Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de> |
| Date: | Sat, 14 Feb 2004 07:28:49 +0100 |
| Cc: | Ralf Baechle <ralf@linux-mips.org>, David Daney <ddaney@avtrex.com>, "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>, linux-mips@linux-mips.org |
| In-reply-to: | <20040214061353.GA21449@mvista.com> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <Pine.LNX.4.55.0402131453360.15042@jurand.ds.pg.gda.pl> <20040213145316.GA23810@linux-mips.org> <20040213222253.GA20118@rembrandt.csv.ica.uni-stuttgart.de> <402D513F.8080205@avtrex.com> <20040213224959.GB20118@rembrandt.csv.ica.uni-stuttgart.de> <20040214011539.GB31847@linux-mips.org> <20040214012801.GC20118@rembrandt.csv.ica.uni-stuttgart.de> <20040214014520.GA4588@linux-mips.org> <20040214021740.GE20118@rembrandt.csv.ica.uni-stuttgart.de> <20040214061353.GA21449@mvista.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mutt/1.5.5.1i |
Jun Sun wrote:
> On Sat, Feb 14, 2004 at 03:17:40AM +0100, Thiemo Seufer wrote:
> > Ralf Baechle wrote:
> > [snip]
> > > Anyway, gcc could load next weeks lucky lottery numbers into the
> > > s-registers after saving them. That'd break save_static but not the
> > > ABI which only promises to restore the old values in s-registers on
> > > return.
> >
> > Ok, it could, but adding such insns to the prologue wouldn't make
> > sense at all, so this is unlikely to happen.
> >
>
> OS people who have been around long enough know "unlikely" things
> always end up happening. :)
[snip]
> sys_sigsuspend(struct pt_regs regs)
> {
> 8008e280: 27bdffc0 addiu $sp,$sp,-64
> 8008e284: afb00030 sw $s0,48($sp)
> sigset_t *uset, saveset, newset;
>
> save_static(®s);
Which is a compiler bug, because it schedules around __asm__ __volatile__,
but not a breakage caused by the prologue.
There's no way to be safe from broken compilers.
Thiemo
|
| Previous by Date: | Re: [patch] Prevent dead code/data removal with gcc 3.4, Jun Sun |
|---|---|
| Next by Date: | [PATCH][2.4] Changed clock function for vr41xx, Yoichi Yuasa |
| Previous by Thread: | Re: [patch] Prevent dead code/data removal with gcc 3.4, Jun Sun |
| Next by Thread: | Re: [patch] Prevent dead code/data removal with gcc 3.4, Daniel Jacobowitz |
| Indexes: | [Date] [Thread] [Top] [All Lists] |