linux-mips
[Top] [All Lists]

Re: [patch] dump_tlb.c clean-ups

To: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Subject: Re: [patch] dump_tlb.c clean-ups
From: Ralf Baechle <ralf@linux-mips.org>
Date: Tue, 10 Feb 2004 17:34:07 +0100
Cc: linux-mips@linux-mips.org
In-reply-to: <Pine.LNX.4.55.0402101653290.6769@jurand.ds.pg.gda.pl>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <Pine.LNX.4.55.0402101653290.6769@jurand.ds.pg.gda.pl>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4.1i
On Tue, Feb 10, 2004 at 05:15:39PM +0100, Maciej W. Rozycki wrote:

> Ralf,
> 
>  Gcc 3.4 complains about a possibly undefined operation in dump16() in 
> arch/mips/lib/r3k_dump_tlb.c.  The following patch fixes it.  I've taken 
> the opportunity to clean up the file and its counterparts thus:
> 
> 1. I've cast the pointers to "unsigned long" consistently for output
> formatting as the width specifier doesn't work very well with pointers.
> 
> 2. I've renamed msg2str() to msk2str() in one of the variations.
> 
> 3. I've reordered header inclusions in one of the variations.
> 
> 4. I've fixed indentation throughout, perhaps not completely, but still 
> the result should be somewhat closer to sanity.
> 
> These changes make the three variations closer to one another where 
> possible.
> 
>  OK to apply?

Sure, go ahead.

I guess the output format could also use some improvments for readability ...

  Ralf

<Prev in Thread] Current Thread [Next in Thread>