[Top] [All Lists]

Re: [PATCH 2.6] enable genrtc for MIPS

To: Atsushi Nemoto <>
Subject: Re: [PATCH 2.6] enable genrtc for MIPS
From: Jun Sun <>
Date: Mon, 2 Feb 2004 13:19:50 -0800
In-reply-to: <>; from on Sun, Feb 01, 2004 at 08:30:05PM +0900
Original-recipient: rfc822;
References: <> <> <>
User-agent: Mutt/1.2.5i
On Sun, Feb 01, 2004 at 08:30:05PM +0900, Atsushi Nemoto wrote:
> By the way, with this patch, individual board can not implement it's
> own genrtc routines.  How about making gen_rtc_time, etc. pointer to
> functions to allow overrides?

Is this necessary?  How about letting us wait until there is a sensible

> I think implementing rtc_get_time (mips specific) with get_rtc_time
> (genrtc) is more efficient than implementing get_rtc_time with
> rtc_get_time for most RTC chips.

If I understand you correctly, you like to have board rtc read routines to 
return a rtc structure instead of the unsigned long integer.

There are actually boards which makes the current implementation more 
See vr4181.

In general, however, this is not a bad idea, just involving a lot more
board level changes.  I think it deserves another patch or even debate.


<Prev in Thread] Current Thread [Next in Thread>