linux-mips
[Top] [All Lists]

Re: [PATCH 2.6] set up conswitchp when CONFIG_VT is set

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH 2.6] set up conswitchp when CONFIG_VT is set
From: Jun Sun <jsun@mvista.com>
Date: Thu, 22 Jan 2004 14:44:05 -0800
Cc: Geert Uytterhoeven <geert@linux-m68k.org>, Linux/MIPS Development <linux-mips@linux-mips.org>, jsun@mvista.com
In-reply-to: <20040122221820.GA23391@linux-mips.org>; from ralf@linux-mips.org on Thu, Jan 22, 2004 at 11:18:20PM +0100
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20040121162032.F29705@mvista.com> <Pine.GSO.4.58.0401221052100.1408@waterleaf.sonytel.be> <20040122122832.GA4482@linux-mips.org> <Pine.GSO.4.58.0401221331160.1408@waterleaf.sonytel.be> <20040122221820.GA23391@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.2.5i
On Thu, Jan 22, 2004 at 11:18:20PM +0100, Ralf Baechle wrote:
> On Thu, Jan 22, 2004 at 01:32:58PM +0100, Geert Uytterhoeven wrote:
> 
> > DUMMY_CONSOLE can be set in drivers/video/console/Kconfig only.
> > drivers/video/console/Kconfig is included by drivers/video/Kconfig only, and
> > its inclusion depends on VT.
> > Hence the #ifdef CONFIG_VT is superfluous, unless the above isn't true for 
> > the
> > MIPS tree (I checked plain 2.6.1).
> 
> A few systems used to hardwire CONFIG_DUMMY_CONSOLE in their Config.in /
> Kconfig.  Seem that has been fixed, good.
> 

You are both right.  

In the end conswitchp needs to be set if and only if CONFIG_VT is set.  
From this regard, I think it is OK to leave this config there even if 
not all that useful given current code.

OK, I admit.  I already checked it in that way :0  If anyone is seriously
mad, I can take it out.  It does not really matter.  What really
matters is we repealed another unnecessary tax on board part.

Jun

PS. the tax repealling thing is really learned from our governer Arnold
Schwarzenegger ....


<Prev in Thread] Current Thread [Next in Thread>