| To: | Geert Uytterhoeven <geert@linux-m68k.org> |
|---|---|
| Subject: | Re: [PATCH 2.6] set up conswitchp when CONFIG_VT is set |
| From: | Ralf Baechle <ralf@linux-mips.org> |
| Date: | Thu, 22 Jan 2004 13:28:32 +0100 |
| Cc: | Jun Sun <jsun@mvista.com>, Linux/MIPS Development <linux-mips@linux-mips.org> |
| In-reply-to: | <Pine.GSO.4.58.0401221052100.1408@waterleaf.sonytel.be> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <20040121162032.F29705@mvista.com> <Pine.GSO.4.58.0401221052100.1408@waterleaf.sonytel.be> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mutt/1.4.1i |
On Thu, Jan 22, 2004 at 10:52:59AM +0100, Geert Uytterhoeven wrote: > | +#ifdef CONFIG_VT > | +#if defined(CONFIG_VGA_CONSOLE) > | + conswitchp = &vga_con; > | +#elif defined(CONFIG_DUMMY_CONSOLE) > | + conswitchp = &dummy_con; > | +#endif > | +#endif > > Isn't the #ifdef CONFIG_VT superfluous? No; if CONFIG_VT is undefined conswitchp is undefined also; DUMMY_CONSOLE however is still selectable if CONFIG_VT is off so there could be unsatisfied references to consitchp. ralf |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: access_ok and CONFIG_MIPS32 for 2.6, Atsushi Nemoto |
|---|---|
| Next by Date: | Re: [PATCH 2.6] set up conswitchp when CONFIG_VT is set, Geert Uytterhoeven |
| Previous by Thread: | Re: [PATCH 2.6] set up conswitchp when CONFIG_VT is set, Geert Uytterhoeven |
| Next by Thread: | Re: [PATCH 2.6] set up conswitchp when CONFIG_VT is set, Geert Uytterhoeven |
| Indexes: | [Date] [Thread] [Top] [All Lists] |