linux-mips
[Top] [All Lists]

Re: [PATCH][2.6] Update NEC VRC4171 PCMCIA driver

To: Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH][2.6] Update NEC VRC4171 PCMCIA driver
From: Yoichi Yuasa <yuasa@hh.iij4u.or.jp>
Date: Sun, 18 Jan 2004 11:53:21 +0900
Cc: yuasa@hh.iij4u.or.jp, ralf@linux-mips.org, linux-mips@linux-mips.org
In-reply-to: <20040116123352.GA13006@lst.de>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20040116083821.6b65c69f.yuasa@hh.iij4u.or.jp> <20040116123352.GA13006@lst.de>
Sender: linux-mips-bounce@linux-mips.org
On Fri, 16 Jan 2004 13:33:52 +0100
Christoph Hellwig <hch@lst.de> wrote:

> On Fri, Jan 16, 2004 at 08:38:21AM +0900, Yoichi Yuasa wrote:
> > +static int pccard_register_callback(unsigned int slot,
> > +                                    void (*handler)(void *, unsigned int),
> > +                                    void *info)
> > +{
> > +   vrc4171_socket_t *socket;
> > +
> > +   if (slot >= CARD_MAX_SLOTS)
> > +           return -EINVAL;
> > +
> > +   socket = &vrc4171_sockets[slot];
> > +
> > +   socket->handler = handler;
> > +   socket->info = info;
> > +
> > +   if (handler)
> > +           MOD_INC_USE_COUNT;
> > +   else
> > +           MOD_DEC_USE_COUNT;
> > +
> > +   return 0;
> > +}
> 
> This is most certainly wrong.  Module refcounting handling has moved one
> layer up in 2.6.
> 

Oops, I sent old one.
Wait a moment.

Yoichi

<Prev in Thread] Current Thread [Next in Thread>