linux-mips
[Top] [All Lists]

Re: Assembler error in arch/mips/kernel/entry.S

To: Jö Fahlke <jorrit@jorrit.de>
Subject: Re: Assembler error in arch/mips/kernel/entry.S
From: Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de>
Date: Tue, 6 Jan 2004 19:14:56 +0100
Cc: Linux on Mips Mailinglist <linux-mips@linux-mips.org>, Ralf Baechle <ralf@linux-mips.org>
In-reply-to: <20040106163925.GA7342@fsk.uni-heidelberg.de>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20040106163925.GA7342@fsk.uni-heidelberg.de>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.4i
Jö Fahlke wrote:
[snip]
> ======================================================================
>         beqz    restore_all
>         if (in_exception_path)
>                 goto restore_all;
>         li      t0, PREEMPT_ACTIVE
> ======================================================================
> 
> Can someone please fix this?  My very limitet assembler knowledge
> gives me an idea whats wrong, but I don't know how to fix it.

The appended guesswork may help.


Thiemo


Index: entry.S
===================================================================
RCS file: /home/cvs/linux/arch/mips/kernel/entry.S,v
retrieving revision 1.58
diff -u -p -r1.58 entry.S
--- entry.S     30 Oct 2003 01:50:28 -0000      1.58
+++ entry.S     6 Jan 2004 18:11:23 -0000
@@ -52,9 +52,7 @@ ENTRY(resume_kernel)
 need_resched:
        LONG_L  t0, TI_FLAGS($28)
        andi    t1, t0, _TIF_NEED_RESCHED
-       beqz    restore_all
-       if (in_exception_path)
-               goto restore_all;
+       beqz    t1, restore_all
        li      t0, PREEMPT_ACTIVE
        sw      t0, TI_PRE_COUNT($28)
        local_irq_enable t0

<Prev in Thread] Current Thread [Next in Thread>