linux-mips
[Top] [All Lists]

Re: [PATCH] au1k_ir - fix for 2.6

To: jt@hpl.hp.com
Subject: Re: [PATCH] au1k_ir - fix for 2.6
From: Pete Popov <ppopov@mvista.com>
Date: 11 Dec 2003 12:06:07 -0800
Cc: Stephen Hemminger <shemminger@osdl.org>, Jeff Garzik <jgarzik@pobox.com>, Ralf Baechle <ralf@gnu.org>, Linux MIPS mailing list <linux-mips@linux-mips.org>, irda-users@sourceforge.net
In-reply-to: <20031210002214.GA12272@bougret.hpl.hp.com>
Organization: MontaVista Software
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20031209155440.2615b9cc.shemminger@osdl.org> <20031210002214.GA12272@bougret.hpl.hp.com>
Sender: linux-mips-bounce@linux-mips.org
On Tue, 2003-12-09 at 16:22, Jean Tourrilhes wrote:
> On Tue, Dec 09, 2003 at 03:54:40PM -0800, Stephen Hemminger wrote:
> > This fixes some of the issues with the Alchemy irda driver for MIPS on
> > 2.6.0-test11.  Tested with cross compile.  This driver is probably obsolete
> > but it is one of the two remaining users of dev_alloc
> > 
> > Changes:
> >     * irqreturn_t for irq routine
> >     * alloc_irdadev instead of dev_alloc
> >     * should work as non module
> > 
> > Some mips build notes:
> >     * no way to enable the device at present since drivers/net/irda/Kconfig
> >       expects MIPS_A1000 and arch/mips/Kconfig defines SOC_AU1000!
> >     * include/asm-mips/timex.h does not define CLOCK_TICK_RATE for this
> >       that type.  Code should probably be:
> > 
> > #ifdef CONFIG_SGI_IP22
> > #define CLOCK_TICK_RATE             1000000
> > #else
> > #define CLOCK_TICK_RATE             1193182
> > #endif
> 
>       I don't have the hardware and I'm not familiar with MIPS, so
> if the authors doesn't answer, we will merge your patch as is.

Go ahead.

Pete


<Prev in Thread] Current Thread [Next in Thread>