Re: CVS Update@-mips.org: linux

["Maciej W. Rozycki" <macro@ds2.pg.gda.pl>]

On Mon, 3 Nov 2003 ralf@linux-mips.org wrote:

> Modified files:
>       include/asm-mips: i8259.h
>
> Log message:
>       Declare i8259A_lock spinlock.  New inline function i8259_irq to poll
>       interrupts in a PC-style daisy-chained i8259 configuration where no
>       better method to execute an interrupt acknowledge cycle is available.

 This is broken -- you do want to check bit #7 for spurious interrupts
instead of doing awkward PIC poking.  Alternatively, just skip the check
-- the condition is rare and handlers need to be able to deal with it
anyway.  It was discussed a few months ago and I proposed a correct patch
similar to your one, but it was rejected, sigh...

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +