linux-mips
[Top] [All Lists]

Possible Missing include in arch/mips/kernel/vmlinux.lds.S

To: linux-mips@linux-mips.org
Subject: Possible Missing include in arch/mips/kernel/vmlinux.lds.S
From: "Noah J. Misch" <noah@caltech.edu>
Date: Tue, 7 Oct 2003 12:46:44 -0700 (PDT)
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
Please CC:/To: relevant messages to me; I do not subscribe to linux-mips.

Executive summary: File in subject line may need #include <linux/config.h>

I just wrote a new version of scripts/configcheck.pl, the script that runs
when you call 'make configcheck' in a linux source tree.  This script is
supposed to find files that need to include linux/config.h but do not
include it, and vice-versa.  I found only one file in the 2.6.0-test6 tree
that needs config.h and does not include it[1]:

arch/mips/kernel/vmlinux.lds.S

This file uses CONFIG_BOOT_ELF64, CONFIG_MIPS32, and CONFIG_MIPS64, but
neither it nor the one file it includes, asm-generic/vmlinux.lds.h,
include linux/config.h.  This is true both in the linux-2.6.0-test6
version, and also in the linux-mips CVS tree as of 3:00 PM 10/7/2003.

I don't use linux-mips myself, so I haven't verified this issue with a
real toolchain.  It seems pretty clear-cut, but if I'm mistaken, would one
of you send me arch/mips/kernel/.vmlinux.lds.s.cmd from the tree of a
built kernel so I can fix my methodology? :)

[1] That is, in a way that would cause bugs right now.  Many, many files
need config.h but include it only indirectly, and many files need config.h
but never compile standalone.  I found only one file that does not fall
into either category.


<Prev in Thread] Current Thread [Next in Thread>
  • Possible Missing include in arch/mips/kernel/vmlinux.lds.S, Noah J. Misch <=