linux-mips
[Top] [All Lists]

Re: [PATCH] Fix character loss in drivers/tc/zs.c

To: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Subject: Re: [PATCH] Fix character loss in drivers/tc/zs.c
From: Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de>
Date: Tue, 23 Sep 2003 10:40:05 +0200
Cc: linux-mips@linux-mips.org
In-reply-to: <Pine.GSO.3.96.1030922193409.25762B-100000@delta.ds2.pg.gda.pl>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20030921213104.GO13578@rembrandt.csv.ica.uni-stuttgart.de> <Pine.GSO.3.96.1030922193409.25762B-100000@delta.ds2.pg.gda.pl>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.4i
Maciej W. Rozycki wrote:
> On Sun, 21 Sep 2003, Thiemo Seufer wrote:
> 
> > this patch reduces the zs driver's character lossage.
> 
>  Can you please elaborate?  tty is expected to be NULL if info->hook is
> not, so the code after the change should not differ effectively -- only a
> useless check is added at the end.  Am I missing anything?

AFAICS the

        while ((read_zsreg(info->zs_channel, R0) & Rx_CH_AV) != 0) {

loops over the FIFO contents and 'return' discards the remaining
part. The patch made a visible difference for me with some noisy
debug printk()'s in the kernel.


Thiemo

<Prev in Thread] Current Thread [Next in Thread>