Re: [PATCH] Fix character loss in drivers/tc/zs.c

[Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de>]

Maciej W. Rozycki wrote:
> On Sun, 21 Sep 2003, Thiemo Seufer wrote:
> 
> > this patch reduces the zs driver's character lossage.
> 
>  Can you please elaborate?  tty is expected to be NULL if info->hook is
> not, so the code after the change should not differ effectively -- only a
> useless check is added at the end.  Am I missing anything?

AFAICS the

        while ((read_zsreg(info->zs_channel, R0) & Rx_CH_AV) != 0) {

loops over the FIFO contents and 'return' discards the remaining
part. The patch made a visible difference for me with some noisy
debug printk()'s in the kernel.


Thiemo