Re: [PATCH] PMAG-AA Hardware cursor support

["Maciej W. Rozycki" <macro@ds2.pg.gda.pl>]

On Sun, 21 Sep 2003, Thiemo Seufer wrote:

> @@ -37,8 +37,7 @@ static inline void bt455_read_cmap_entry
>                                        u8* red, u8* green, u8* blue)
>  {
>       bt455_select_reg(regs, cr);
> -     
> -     mb();
> +     rmb();
>       *red = regs->addr_cmap_data & 0x0f;
>       rmb();
>       *green = regs->addr_cmap_data & 0x0f;

 I do think it has to be an mb() as the first access is a write and the
second one is a read. 

 You may also consider using ISO C initializers for struct members -- I
can do the conversion myself, but since you are actively working on the
code right now, I guess it might give you an unnecessary burden of chasing
the changing master sources.

  Maciej

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +