linux-mips
[Top] [All Lists]

Re: [PATCH] PMAG-AA Hardware cursor support

To: Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de>
Subject: Re: [PATCH] PMAG-AA Hardware cursor support
From: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Date: Mon, 22 Sep 2003 19:53:46 +0200 (MET DST)
Cc: linux-mips@linux-mips.org
In-reply-to: <20030921212313.GN13578@rembrandt.csv.ica.uni-stuttgart.de>
Organization: Technical University of Gdansk
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
On Sun, 21 Sep 2003, Thiemo Seufer wrote:

> @@ -37,8 +37,7 @@ static inline void bt455_read_cmap_entry
>                                        u8* red, u8* green, u8* blue)
>  {
>       bt455_select_reg(regs, cr);
> -     
> -     mb();
> +     rmb();
>       *red = regs->addr_cmap_data & 0x0f;
>       rmb();
>       *green = regs->addr_cmap_data & 0x0f;

 I do think it has to be an mb() as the first access is a write and the
second one is a read. 

 You may also consider using ISO C initializers for struct members -- I
can do the conversion myself, but since you are actively working on the
code right now, I guess it might give you an unnecessary burden of chasing
the changing master sources.

  Maciej

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +


<Prev in Thread] Current Thread [Next in Thread>