linux-mips
[Top] [All Lists]

Re: ddb5477 fixes for 2.6

To: Daniel Jacobowitz <dan@debian.org>
Subject: Re: ddb5477 fixes for 2.6
From: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Date: Thu, 18 Sep 2003 19:19:21 +0200 (MET DST)
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
In-reply-to: <20030918170642.GA22753@nevyn.them.org>
Organization: Technical University of Gdansk
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
On Thu, 18 Sep 2003, Daniel Jacobowitz wrote:

> >  Is it OK for other PCI systems?
> 
> Yes, I think so.  Those two functions seem to have migrated in from
> pci-hplj.c; they can't possibly compile, since they use constants only
> defined in that file.

 Then the snippet should probably get removed altogether.

> >  Why do you want these suffixes?  They don't work for assembly sources.
> 
> Because otherwise uses of XKPHYS in a 32-bit kernel generate noisy
> warnings.  I don't remember where it was offhand.  Wrap it in
> __ASSEMBLY__ if you like.

 Hmm, but is there any use for XKPHYS, etc. in a 32-bit kernel at all? 
The address cannot effectively be used anyway. 

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +


<Prev in Thread] Current Thread [Next in Thread>