linux-mips
[Top] [All Lists]

Re: [PATCH] sibyte patch for 2.6 ide.h

To: Kip Walker <kwalker@broadcom.com>
Subject: Re: [PATCH] sibyte patch for 2.6 ide.h
From: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Date: Fri, 5 Sep 2003 18:57:23 +0200 (MET DST)
Cc: linux-mips@linux-mips.org
In-reply-to: <3F567D4A.BA3FD396@broadcom.com>
Organization: Technical University of Gdansk
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
On Wed, 3 Sep 2003, Kip Walker wrote:

> Any objection to the following patch, which lets IDE work on 2.6 for
> SiByte platforms?  Before getting it checked in, I'm willing to hear
> style comments.  I need extra work to happen in ide_init_default_hwifs,
> but that code doesn't fit well in <asm/ide.h> because most of the useful
> declarations in <linux/ide.h> haven't been made yet.  With this patch, I
> hoist the code into a C file, but can call back into the existing code
> (avoiding maintaining a duplicate).

 Hmm, dumb question -- can't your extra work be done in code specific to
the host-adapter?  The ide_init_default_hwifs() function looks like ISA
legacy.

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +


<Prev in Thread] Current Thread [Next in Thread>