linux-mips
[Top] [All Lists]

Re: GPIO support for db1100

To: Yasushi SHOJI <Yasushi.SHOJI@atmark-techno.com>
Subject: Re: GPIO support for db1100
From: Pete Popov <ppopov@mvista.com>
Date: 19 Aug 2003 17:07:52 -0700
Cc: Linux MIPS mailing list <linux-mips@linux-mips.org>
In-reply-to: <20030820000223.8D1233E614@dns1.atmark-techno.com>
Organization: MontaVista Software
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20030819015408.312713E614@dns1.atmark-techno.com> <1061309193.1488.450.camel@zeus.mvista.com> <20030820000223.8D1233E614@dns1.atmark-techno.com>
Sender: linux-mips-bounce@linux-mips.org
On Tue, 2003-08-19 at 17:02, Yasushi SHOJI wrote:
> At 19 Aug 2003 09:06:33 -0700,
> Pete Popov wrote:
> > 
> > On Mon, 2003-08-18 at 18:54, Yasushi SHOJI wrote:
> > > Steve and all,
> > > 
> > > I'd like to add gpio support to db1100 and/or au1100.
> > > 
> > > since there already is au1000_gpio.c in driver/char, should I go
> > > fixing and renaming au1000_gpio.c to au1x00_gpio.c or create
> > > au1100_gpio.c and asm-mips/au1100_gpio.h?
> > 
> > Why do you need to rename the file? The only way to do that with cvs is
> > to delete it and add the new file, and then you lose all cvs log info.
> > It would have been nice to have named the file au1x00_gpio instead of
> > au1000_gpio, but I don't think that's critical to using the driver.
> 
> I agree that file name is not critial at all.
> 
> so should I go with ifdef's to add au1100's primary and secondary gpio
> support in au1000_gpio.c?
> 
> yes, even with primary gpio, pin assign differ between au1000 and
> au1100. that means avail_mask in struct pinfuc_to_avail must change,
> IMHO.

Well, if there's too many changes, then perhaps a new driver is in
order. The secondary gpio on the au1100 and au1500 are similar, I think.
Perhaps you can make the driver work on both CPUs :)?

Pete


<Prev in Thread] Current Thread [Next in Thread>