On Tue, 19 Aug 2003, Ralf Baechle wrote:
> > > > #ifdef __mips64
> > > > # define MFC0 dmfc0
> > > > # define MTC0 dmtc0
> > > > #else
> > > > # define MFC0 mfc0
> > > > # define MTC0 mtc0
> > > > #endif
> > >
> > > I'd go for CONFIG_MIPS64 here.
> >
> > This would work as well, but I prefer compiler intrinsic defines
> > over custom configury.
>
> I agree for this particular header file because it's been copied into
> user applications. So ideally it should be able to live entirely without
> CONFIG_* symbols rsp. <linux/config.h>.
OK, I now recall <asm/asm.h> and <asm/regdef.h> as traditionally being
often included in user assembly. But then we should get rid of
configuration dependency entirely, i.e. remove "#include <linux/config.h>"
and a CONFIG_CPU_HAS_PREFETCH dependency. Perhaps <asm/pref.h> would be
desireable if we don't want wasting cycles.
It's a pity a more reasonable choice wasn't made for the location of
these headers -- the asm and linux trees shouldn't really be used for
userland. For example Alpha has <alpha/regdef.h> that comes from glibc.
--
+ Maciej W. Rozycki, Technical University of Gdansk, Poland +
+--------------------------------------------------------------+
+ e-mail: macro@ds2.pg.gda.pl, PGP key available +
|