linux-mips
[Top] [All Lists]

Re: [PATCH] kill prom_printf

To: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Subject: Re: [PATCH] kill prom_printf
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Tue, 17 Jun 2003 17:12:06 +0200 (MEST)
Cc: Ladislav Michl <ladis@linux-mips.org>, Juan Quintela <quintela@trasno.org>, Linux/MIPS Development <linux-mips@linux-mips.org>
In-reply-to: <Pine.GSO.3.96.1030617164642.22214J-100000@delta.ds2.pg.gda.pl>
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
On Tue, 17 Jun 2003, Maciej W. Rozycki wrote:
> On Tue, 17 Jun 2003, Geert Uytterhoeven wrote:
> > >  Hmm, calling the firmware for each character separately will certainly be
> > > terribly slow, though it may be negligible as normally few messages will
> > > be output this way.  And since the call to prom_printf() is so cheap for
> > > the DECstation, I'm going to retain the function for real low-level
> > > debugging, whether otherwise used or not. 
> > 
> > kernel/printk.c doesn't call the low-level output routine for each character
> > separately, but passes complete strings of characters.
> 
>  So I can just call prom_printf("%s", string), right?  This would solve
> this shortcoming. 

More or less. The caveat is that console->write() is not called with a
NULL-terminated string, but with a pointer and a length.

Gr{oetje,eeting}s,

                                                Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                                            -- Linus Torvalds


<Prev in Thread] Current Thread [Next in Thread>