linux-mips
[Top] [All Lists]

Re: CVS Update@-mips.org: linux

To: linux-mips@linux-mips.org, ralf@linux-mips.org
Subject: Re: CVS Update@-mips.org: linux
From: Atsushi Nemoto <nemoto@toshiba-tops.co.jp>
Date: Mon, 16 Jun 2003 10:42:24 +0900 (JST)
In-reply-to: <20030616.101911.07647456.nemoto@toshiba-tops.co.jp>
Organization: TOSHIBA Personal Computer System Corporation
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20030615004718Z8225220-1272+2582@linux-mips.org> <20030616.101911.07647456.nemoto@toshiba-tops.co.jp>
Sender: linux-mips-bounce@linux-mips.org
>>>>> On Mon, 16 Jun 2003 10:19:11 +0900 (JST), Atsushi Nemoto 
>>>>> <nemoto@toshiba-tops.co.jp> said:
>>>>> On Sun, 15 Jun 2003 01:47:13 +0100, ralf@linux-mips.org said:
>> Modified files:
>> arch/mips64    : Tag: linux_2_4 Makefile 
>> include/asm-mips64: Tag: linux_2_4 processor.h r4kcache.h 

>> Log message:
>> Support GT64120 boards with 64-bit kernels also.

nemoto> This corrupts mips64/mm/c-r4k.c.  Please apply this patch also.

And I doubt that 'unsigned short' is enough for the 'waysize'
(especially for scache).  How about this?

diff -u linux-mips-cvs/include/asm-mips64/processor.h 
linux.new/include/asm-mips64/processor.h
--- linux-mips-cvs/include/asm-mips64/processor.h       Mon Jun 16 09:33:42 2003
+++ linux.new/include/asm-mips64/processor.h    Mon Jun 16 10:40:19 2003
@@ -50,8 +50,8 @@
        unsigned short linesz;  /* Size of line in bytes */
        unsigned short ways;    /* Number of ways */
        unsigned short sets;    /* Number of lines per set */
-       unsigned short waysize; /* Bytes per way */
-       unsigned int waybit;    /* Bits to select in a cache set */
+       unsigned short waybit;  /* Bits to select in a cache set */
+       unsigned int waysize;   /* Bytes per way */
        unsigned int flags;     /* Flags describing cache properties */
 };
 
---
Atsushi Nemoto

<Prev in Thread] Current Thread [Next in Thread>