linux-mips
[Top] [All Lists]

Re: mips64 LOAD_KPTE2 fix

To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Subject: Re: mips64 LOAD_KPTE2 fix
From: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Date: Wed, 4 Jun 2003 16:09:10 +0200 (MET DST)
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
In-reply-to: <20030604.100204.74756139.nemoto@toshiba-tops.co.jp>
Organization: Technical University of Gdansk
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
On Wed, 4 Jun 2003, Atsushi Nemoto wrote:

> macro> diff -up --recursive --new-file 
> linux-mips-2.4.21-pre4-20030505.macro/arch/mips64/mm/tlbex-r4k.S 
> linux-mips-2.4.21-pre4-20030505/arch/mips64/mm/tlbex-r4k.S
> macro> --- linux-mips-2.4.21-pre4-20030505.macro/arch/mips64/mm/tlbex-r4k.S   
> 2003-04-27 02:56:39.000000000 +0000
> macro> +++ linux-mips-2.4.21-pre4-20030505/arch/mips64/mm/tlbex-r4k.S 
> 2003-06-03 12:54:41.000000000 +0000
> macro> @@ -73,8 +73,9 @@
> macro>         * Determine that fault address is within vmalloc range.
> macro>         */
> macro>        dla     \tmp, ekptbl
> macro> -      sltu    \tmp, \ptr, \tmp
> macro> +      slt     \tmp, \ptr, \tmp
> macro>        beqz    \tmp, \not_vmalloc              # not vmalloc
> macro> +       nop
> macro>        .endm
> 
> 
> Thank you for pointing out this.  I did not think very much.  But you
> mean "slt \tmp, \tmp, \ptr", don't you?

 Not at all.  Why would I want to reverse the comparison? 

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +


<Prev in Thread] Current Thread [Next in Thread>