linux-mips
[Top] [All Lists]

Re: Yet another fix

To: linux-mips@linux-mips.org
Subject: Re: Yet another fix
From: ilya@theIlya.com
Date: Sun, 1 Jun 2003 21:57:00 -0700
In-reply-to: <13249.1054529364@kao2.melbourne.sgi.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20030602041424.GG3035@gateway.total-knowledge.com> <13249.1054529364@kao2.melbourne.sgi.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4i
module_map is referenced in register_ioctl32_conversion in arch/mips64/ioctl32.c
As far as I can see, it should simply be possible to replace module_map
with vmalloc in there, but I am not sure, as I don't know how exactly
ioctl translations work...

On Mon, Jun 02, 2003 at 02:49:24PM +1000, Keith Owens wrote:
> On Sun, 1 Jun 2003 21:14:24 -0700, 
> ilya@theIlya.com wrote:
> >I am not sure this is correct solution to a problem. Or rather, I'm pretty
> >sure it is incorrect one.. There is a reference to module_map somewhere, 
> >however
> >it is not inculded if modules are disabled. Here is sorta fix
> >
> >Index: include/asm-mips64/module.h
> >===================================================================
> >RCS file: /home/cvs/linux/include/asm-mips64/module.h,v
> >retrieving revision 1.5
> >diff -u -r1.5 module.h
> >--- include/asm-mips64/module.h 1 Jun 2003 00:39:15 -0000       1.5
> >+++ include/asm-mips64/module.h 2 Jun 2003 03:59:23 -0000
> >@@ -11,4 +11,8 @@
> > #define Elf_Sym Elf32_Sym
> > #define Elf_Ehdr Elf32_Ehdr
> > 
> >+#ifndef CONFIG_MODULES
> >+#define module_map(x) vmalloc(x)
> >+#endif
> >+
> > #endif /* _ASM_MODULE_H */
> 
> That fix is incorrect.  There should be no references to module_map
> when CONFIG_MODULES=n.  Please find out where module_map is being
> incorrectly used and fix that code.
> 

Attachment: pgpIoVwDuQcKQ.pgp
Description: PGP signature

<Prev in Thread] Current Thread [Next in Thread>