linux-mips
[Top] [All Lists]

Re: [PATCH] Arrow keys on USB keyboards

To: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Subject: Re: [PATCH] Arrow keys on USB keyboards
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Tue, 27 May 2003 15:29:54 +0200 (MEST)
Cc: Ralf Baechle <ralf@linux-mips.org>, Linux/MIPS Development <linux-mips@linux-mips.org>
In-reply-to: <Pine.GSO.3.96.1030527150418.24408B-100000@delta.ds2.pg.gda.pl>
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
On Tue, 27 May 2003, Maciej W. Rozycki wrote:
> On Tue, 27 May 2003, Ralf Baechle wrote:
> > >  Hmm, if the PC/AT keyboard translation is needed by other devices beside
> > > pc_keyb.c, then why isn't the common part put into a separate file to be
> > > used by all devices depending on this translation as needed?  I think
> > > dummy_keyb.c should be kept plain and simple as it is now. 
> > 
> > You're right but for 2.4 this looks like an acceptable solution for now so
> > I'm going to apply this until somebody comes up with a better solution.
> 
>  Hmm, as I've understood that's a 2.4-only problem as 2.5 has it solved
> differently.  And I do think the translation really belong to the drivers
> that use it -- why can't it be included with the USB keyboard driver or as
> a library file?  Why an unrelated driver has to be cluttered? 

It's not really used by a driver, but by the input subsystem itself. You could
add the translation to drivers/char/keyboard.c, but then it will break if you
use both the input subsystem (e.g. USB keyboard) and some other non-PS/2
keyboard driver.

Gr{oetje,eeting}s,

                                                Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                                            -- Linus Torvalds


<Prev in Thread] Current Thread [Next in Thread>