linux-mips
[Top] [All Lists]

Re: [PATCH] Arrow keys on USB keyboards

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] Arrow keys on USB keyboards
From: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Date: Tue, 27 May 2003 15:15:33 +0200 (MET DST)
Cc: Geert Uytterhoeven <geert@linux-m68k.org>, Linux/MIPS Development <linux-mips@linux-mips.org>
In-reply-to: <20030527054649.GA19562@linux-mips.org>
Organization: Technical University of Gdansk
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
On Tue, 27 May 2003, Ralf Baechle wrote:

> >  Hmm, if the PC/AT keyboard translation is needed by other devices beside
> > pc_keyb.c, then why isn't the common part put into a separate file to be
> > used by all devices depending on this translation as needed?  I think
> > dummy_keyb.c should be kept plain and simple as it is now. 
> 
> You're right but for 2.4 this looks like an acceptable solution for now so
> I'm going to apply this until somebody comes up with a better solution.

 Hmm, as I've understood that's a 2.4-only problem as 2.5 has it solved
differently.  And I do think the translation really belong to the drivers
that use it -- why can't it be included with the USB keyboard driver or as
a library file?  Why an unrelated driver has to be cluttered? 

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +


<Prev in Thread] Current Thread [Next in Thread>