linux-mips
[Top] [All Lists]

Re: [PATCH] Arrow keys on USB keyboards

To: Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH] Arrow keys on USB keyboards
From: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Date: Fri, 23 May 2003 16:05:43 +0200 (MET DST)
Cc: Ralf Baechle <ralf@linux-mips.org>, Linux/MIPS Development <linux-mips@linux-mips.org>
In-reply-to: <Pine.GSO.4.21.0305231545030.26586-100000@vervain.sonytel.be>
Organization: Technical University of Gdansk
Original-recipient: rfc822;linux-mips@linux-mips.org
Reply-to: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Sender: linux-mips-bounce@linux-mips.org
On Fri, 23 May 2003, Geert Uytterhoeven wrote:

> This patch fixes the arrow keys (and all other keys that generate E0/E1
> scancode prefixes on AT keyboards) by adding support for E0/E1 scancode
> prefixes to the dummy keyboard driver if CONFIG_INPUT=y.
> 
> Rationale: When using the new input layer (i.e. with a USB keyboard or a 
> custom
> input device), the input layer relies on kbd_translate() in the low-level
> keyboard driver to convert from AT-style scancodes to keycodes. If you don't
> have a PS/2 keyboard interface and don't compile in the PS/2 keyboard driver,
> you have to enable the dummy keyboard driver, which naively assumes that
> keycodes and scancodes are interchangeable. This is correct if you do not have
> a keyboard, but fails for prefixed scancodes if you do have a keyboard which
> uses the new input layer.

 Hmm, if the PC/AT keyboard translation is needed by other devices beside
pc_keyb.c, then why isn't the common part put into a separate file to be
used by all devices depending on this translation as needed?  I think
dummy_keyb.c should be kept plain and simple as it is now. 

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +


<Prev in Thread] Current Thread [Next in Thread>