[Top] [All Lists]

Re: [PATCH] sc-ip22.c cleanup

To: Ladislav Michl <>
Subject: Re: [PATCH] sc-ip22.c cleanup
From: Juan Quintela <>
Date: Thu, 08 May 2003 00:17:18 +0200
Cc:, Ralf Baechle <>
In-reply-to: <20030507202229.GA627@kopretinka> (Ladislav Michl's message of "Wed, 7 May 2003 22:22:29 +0200")
Original-recipient: rfc822;
References: <20030507202229.GA627@kopretinka>
User-agent: Gnus/5.090015 (Oort Gnus v0.15) Emacs/21.2.93
>>>>> "ladis" == Ladislav Michl <> writes:


ladis> +        unsigned long size = ip22_eeprom_read(&sgimc->eeprom, 17);

Defining somewhere what 17 mean could be a good idea :)

Except for that looks like a good gain, you remove a lot fo code :)

Later, Juan.

In theory, practice and theory are the same, but in practice they 
are different -- Larry McVoy

<Prev in Thread] Current Thread [Next in Thread>