| To: | Ladislav Michl <ladis@linux-mips.org> |
|---|---|
| Subject: | Re: [PATCH] sc-ip22.c cleanup |
| From: | Juan Quintela <quintela@mandrakesoft.com> |
| Date: | Thu, 08 May 2003 00:17:18 +0200 |
| Cc: | linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org> |
| In-reply-to: | <20030507202229.GA627@kopretinka> (Ladislav Michl's message of "Wed, 7 May 2003 22:22:29 +0200") |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <20030507202229.GA627@kopretinka> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Gnus/5.090015 (Oort Gnus v0.15) Emacs/21.2.93 |
>>>>> "ladis" == Ladislav Michl <ladis@linux-mips.org> writes: Hi ladis> + unsigned long size = ip22_eeprom_read(&sgimc->eeprom, 17); Defining somewhere what 17 mean could be a good idea :) Except for that looks like a good gain, you remove a lot fo code :) Later, Juan. -- In theory, practice and theory are the same, but in practice they are different -- Larry McVoy |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] SGI Seeq cleanup, Juan Quintela |
|---|---|
| Next by Date: | USB OHCI device port on Alchemy, Jeff Baitis |
| Previous by Thread: | [PATCH] sc-ip22.c cleanup, Ladislav Michl |
| Next by Thread: | [PATCH] implement NVRAM access for Indy, Ladislav Michl |
| Indexes: | [Date] [Thread] [Top] [All Lists] |