linux-mips
[Top] [All Lists]

Re: [PATCH]: load_mmu for SMP systems

To: Kip Walker <kwalker@broadcom.com>
Subject: Re: [PATCH]: load_mmu for SMP systems
From: Ralf Baechle <ralf@linux-mips.org>
Date: Mon, 28 Apr 2003 02:56:39 +0200
Cc: linux-mips@linux-mips.org
In-reply-to: <3EA97D54.6910D49E@broadcom.com>; from kwalker@broadcom.com on Fri, Apr 25, 2003 at 11:24:20AM -0700
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <3EA97D54.6910D49E@broadcom.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.2.5.1i
On Fri, Apr 25, 2003 at 11:24:20AM -0700, Kip Walker wrote:

> In SMP systems, each CPU needs to set up "current_cpu_data.tlbsize". 
> Some CPUs do this initialization in cpu_probe, which is called both by
> init_arch and start_secondary.  However, some CPUs do this in their TLB
> setup code, which is called via load_mmu.  The SMP boot code doesn't
> currently call load_mmu() for the secondary CPUs.  Here's a simple fix
> for the 2.4 tree.

I instead changed cpu-probe to set tlbsize properly.  Nothing wrong with
your patch, it just fits better into my Grand Plan (TM) :-)

> TLB flush routines that have loops running up to tlbsize will lose if
> it's not set properly on all CPUs!

Yeah, they're going to be sort of slow.  There must be a reason for all
those GHz processors ;-)

  Ralf

<Prev in Thread] Current Thread [Next in Thread>