linux-mips
[Top] [All Lists]

Re: [patch] new wait instruction for vr4181

To: Steven Seeger <sseeger@stellartec.com>
Subject: Re: [patch] new wait instruction for vr4181
From: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Date: Fri, 25 Apr 2003 17:55:42 +0200 (MET DST)
Cc: "'Jun Sun'" <jsun@mvista.com>, linux-mips@linux-mips.org
In-reply-to: <079701c30aa8$7de13300$3501a8c0@wssseeger>
Organization: Technical University of Gdansk
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
On Thu, 24 Apr 2003, Steven Seeger wrote:

> I think I figured this out. Could someone look at this and tell me if I did
> it right?

 The ifdefs are unnecessary and clutter the code and you should add a
comment near the handcoded instruction, explaining what it is and possibly
sticking a "FIXME" to it.

 BTW, please try to send patches inline in the future. 

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +


<Prev in Thread] Current Thread [Next in Thread>