linux-mips
[Top] [All Lists]

Re: [pathch] kernel/sched.c bogon?

To: linux-mips@linux-mips.org
Subject: Re: [pathch] kernel/sched.c bogon?
From: "Kip Walker" <kwalker@broadcom.com>
Date: Fri, 25 Apr 2003 08:28:22 -0700
Organization: Broadcom Corp. BPBU
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <3E67EF64.152CFC6C@broadcom.com>
Sender: linux-mips-bounce@linux-mips.org
Ralf?  I'm tying up loose ends between my tree and yours, and hoping to
push some things back.

Kip Walker wrote:
> 
> The comparisons of oldest_idle below trigger compiler warnings and
> should probably be safely type-cast:
> 
> Kip
> 
> Index: kernel/sched.c
> ===================================================================
> RCS file: /home/cvs/linux/kernel/sched.c,v
> retrieving revision 1.64.2.6
> diff -u -r1.64.2.6 sched.c
> --- kernel/sched.c      25 Feb 2003 22:03:13 -0000      1.64.2.6
> +++ kernel/sched.c      7 Mar 2003 00:57:35 -0000
> @@ -282,7 +282,7 @@
>                                 target_tsk = tsk;
>                         }
>                 } else {
> -                       if (oldest_idle == -1ULL) {
> +                       if (oldest_idle == (cycles_t) -1) {
>                                 int prio = preemption_goodness(tsk, p,
> cpu);
> 
>                                 if (prio > max_prio) {
> @@ -294,7 +294,7 @@
>         }
>         tsk = target_tsk;
>         if (tsk) {
> -               if (oldest_idle != -1ULL) {
> +               if (oldest_idle != (cycles_t) -1) {
>                         best_cpu = tsk->processor;
>                         goto send_now_idle;
>                 }


<Prev in Thread] Current Thread [Next in Thread>