linux-mips
[Top] [All Lists]

Re: [patch] new wait instruction for vr4181

To: linux-mips@linux-mips.org
Subject: Re: [patch] new wait instruction for vr4181
From: Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de>
Date: Fri, 25 Apr 2003 00:23:37 +0200
In-reply-to: <079701c30aa8$7de13300$3501a8c0@wssseeger>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20030424112711.E28275@mvista.com> <079701c30aa8$7de13300$3501a8c0@wssseeger>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4i
Steven Seeger wrote:
> I think I figured this out. Could someone look at this and tell me if I did
> it right?
> 
> Thanks.
> 
> -Steve
> 

> --- /root/vr/new/linux-2.4.21.orig/arch/mips/kernel/cpu-probe.c       
> 2003-04-24 05:32:21.000000000 -0700
> +++ ./cpu-probe.c     2003-04-24 14:16:35.000000000 -0700
> @@ -34,6 +34,16 @@
>               ".set\tmips0");
>  }
>  
> +#ifdef CONFIG_VR4181
> +static void vr4181_wait(void)

The GAS source claims all vr41xx have 'standby', so you may probably
rename the function and enable it for all CONFIG_VR41*.

> +{
> +   __asm__(".set\tnoreorder\n"

A \t at the end like
__asm__(".set\tnoreorder\n\t"
gives better formatting, and the last line doesn't need a \n.

> +        ".int 0x42000021\n"

.word is probably more usual.


Thiemo

<Prev in Thread] Current Thread [Next in Thread>