linux-mips
[Top] [All Lists]

Re: Improperly handled case in arch/mips/au1000/common/time.c

To: Jeff Baitis <baitisj@evolution.com>
Subject: Re: Improperly handled case in arch/mips/au1000/common/time.c
From: Jun Sun <jsun@mvista.com>
Date: Tue, 22 Apr 2003 15:56:25 -0700
Cc: Pete Popov <ppopov@mvista.com>, linux-mips@linux-mips.org, jsun@mvista.com
In-reply-to: <20030422125450.E10148@luca.pas.lab>; from baitisj@evolution.com on Tue, Apr 22, 2003 at 12:54:50PM -0700
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20030422125450.E10148@luca.pas.lab>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.2.5i
I think this is a good example to show benefit of code sharing.
There is no good reason for au1x00 boards of not using new time.c.
You get to write less board code, fewer bugs and future proof.

Jun

On Tue, Apr 22, 2003 at 12:54:50PM -0700, Jeff Baitis wrote:
> Pete:
> 
> While struggling to get Linux up on Evolution's custom board based on the
> Au1500, I discovered a poorly handled case in time.c; null interrupts are
> handled should not affect the local IRQ count. (if the local IRQ count is not
> decremented, tests for in_irq() fail.)
> 
> Thanks for taking a look at my patch!
> 
> -Jeff
> 
> Index: time.c
> ===================================================================
> RCS file: /home/cvs/linux/arch/mips/au1000/common/time.c,v
> retrieving revision 1.5.2.10
> diff -u -r1.5.2.10 time.c
> --- time.c      25 Mar 2003 14:30:19 -0000      1.5.2.10
> +++ time.c      22 Apr 2003 19:47:24 -0000
> @@ -114,6 +114,7 @@
>         return;
>  
>  null:
> +       irq_exit(cpu, irq);
>         ack_r4ktimer(0);
>  }
> 
> 

<Prev in Thread] Current Thread [Next in Thread>