linux-mips
[Top] [All Lists]

Re: Improperly handled case in arch/mips/au1000/common/time.c

To: baitisj@evolution.com
Subject: Re: Improperly handled case in arch/mips/au1000/common/time.c
From: Pete Popov <ppopov@mvista.com>
Date: 22 Apr 2003 13:20:21 -0700
Cc: Linux MIPS mailing list <linux-mips@linux-mips.org>
In-reply-to: <20030422125450.E10148@luca.pas.lab>
Organization: MontaVista Software
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20030422125450.E10148@luca.pas.lab>
Sender: linux-mips-bounce@linux-mips.org
Jeff,

Thanks, I'll get to this this week. Are there other outstanding Au
patches that you have sent me and I haven't applied yet? I just got back
from vacation so I'll get to them.

Pete

On Tue, 2003-04-22 at 12:54, Jeff Baitis wrote:
> Pete:
> 
> While struggling to get Linux up on Evolution's custom board based on the
> Au1500, I discovered a poorly handled case in time.c; null interrupts are
> handled should not affect the local IRQ count. (if the local IRQ count is not
> decremented, tests for in_irq() fail.)
> 
> Thanks for taking a look at my patch!
> 
> -Jeff
> 
> Index: time.c
> ===================================================================
> RCS file: /home/cvs/linux/arch/mips/au1000/common/time.c,v
> retrieving revision 1.5.2.10
> diff -u -r1.5.2.10 time.c
> --- time.c      25 Mar 2003 14:30:19 -0000      1.5.2.10
> +++ time.c      22 Apr 2003 19:47:24 -0000
> @@ -114,6 +114,7 @@
>         return;
>  
>  null:
> +       irq_exit(cpu, irq);
>         ack_r4ktimer(0);
>  }
> 
> 


<Prev in Thread] Current Thread [Next in Thread>