| To: | Ralf Baechle <ralf@linux-mips.org> |
|---|---|
| Subject: | Re: [patch] TANBAC TB0226(NEC VR4131) for v2.5 |
| From: | Juan Quintela <quintela@mandrakesoft.com> |
| Date: | Tue, 22 Apr 2003 14:15:04 +0200 |
| Cc: | Geert Uytterhoeven <geert@linux-m68k.org>, Yoichi Yuasa <yuasa@hh.iij4u.or.jp>, Linux/MIPS Development <linux-mips@linux-mips.org> |
| In-reply-to: | <20030422140007.C15285@linux-mips.org> (Ralf Baechle's message of "Tue, 22 Apr 2003 14:00:07 +0200") |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <20030422133642.A15285@linux-mips.org> <Pine.GSO.4.21.0304221338360.16017-100000@vervain.sonytel.be> <20030422140007.C15285@linux-mips.org> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Gnus/5.090015 (Oort Gnus v0.15) Emacs/21.2.93 |
>>>>> "ralf" == Ralf Baechle <ralf@linux-mips.org> writes: ralf> On Tue, Apr 22, 2003 at 01:40:19PM +0200, Geert Uytterhoeven wrote: >> > I don't think there's much point in using ISO style initializers >> > everywhere. >> > So far the convention is only to replace the GNU-style inializer. >> > We unfortunately have a few places where the code got inflated by at least >> > the factor of 3 because now some code uses the ISO initializers for >> > everything - for no good reason. >> >> What if someone will change struct resource in the future? ralf> For the generic case that concern may be true - but I don't think struct ralf> resource will change any time soon. Imagine fixing all the drivers ... Did you noticed that "they" changed the modules? and bio? /me think that we have already had enough _big_ breakages to learn that not using named initializers is a bad idea. Later, Juan. -- In theory, practice and theory are the same, but in practice they are different -- Larry McVoy |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [patch] TANBAC TB0226(NEC VR4131) for v2.5, Ralf Baechle |
|---|---|
| Next by Date: | Re: TX39 fixes and cleanups, Atsushi Nemoto |
| Previous by Thread: | Re: [patch] TANBAC TB0226(NEC VR4131) for v2.5, Ralf Baechle |
| Next by Thread: | Re: [patch] TANBAC TB0226(NEC VR4131) for v2.5, Yoichi Yuasa |
| Indexes: | [Date] [Thread] [Top] [All Lists] |