linux-mips
[Top] [All Lists]

Re: [patch] TANBAC TB0226(NEC VR4131) for v2.5

To: Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [patch] TANBAC TB0226(NEC VR4131) for v2.5
From: Ralf Baechle <ralf@linux-mips.org>
Date: Tue, 22 Apr 2003 14:00:07 +0200
Cc: Juan Quintela <quintela@mandrakesoft.com>, Yoichi Yuasa <yuasa@hh.iij4u.or.jp>, Linux/MIPS Development <linux-mips@linux-mips.org>
In-reply-to: <Pine.GSO.4.21.0304221338360.16017-100000@vervain.sonytel.be>; from geert@linux-m68k.org on Tue, Apr 22, 2003 at 01:40:19PM +0200
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20030422133642.A15285@linux-mips.org> <Pine.GSO.4.21.0304221338360.16017-100000@vervain.sonytel.be>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.2.5.1i
On Tue, Apr 22, 2003 at 01:40:19PM +0200, Geert Uytterhoeven wrote:

> > I don't think there's much point in using ISO style initializers everywhere.
> > So far the convention is only to replace the GNU-style inializer.
> > We unfortunately have a few places where the code got inflated by at least
> > the factor of 3 because now some code uses the ISO initializers for
> > everything - for no good reason.
> 
> What if someone will change struct resource in the future?

For the generic case that concern may be true - but I don't think struct
resource will change any time soon.  Imagine fixing all the drivers ...

  Ralf

<Prev in Thread] Current Thread [Next in Thread>