linux-mips
[Top] [All Lists]

Re: [patch] TANBAC TB0226(NEC VR4131) for v2.5

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [patch] TANBAC TB0226(NEC VR4131) for v2.5
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Tue, 22 Apr 2003 13:40:19 +0200 (MEST)
Cc: Juan Quintela <quintela@mandrakesoft.com>, Yoichi Yuasa <yuasa@hh.iij4u.or.jp>, Linux/MIPS Development <linux-mips@linux-mips.org>
In-reply-to: <20030422133642.A15285@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
On Tue, 22 Apr 2003, Ralf Baechle wrote:
> On Tue, Apr 22, 2003 at 01:17:21PM +0200, Juan Quintela wrote:
> > yoichi> +static struct resource vr41xx_pci_mem_resource = {
> > yoichi> +   "PCI memory space",
> > yoichi> +   VR41XX_PCI_MEM_START,
> > yoichi> +   VR41XX_PCI_MEM_END,
> > yoichi> +   IORESOURCE_MEM
> > yoichi> +};
> > 
> > Please, use C99 named initializers in the whole file.
> 
> I don't think there's much point in using ISO style initializers everywhere.
> So far the convention is only to replace the GNU-style inializer.
> We unfortunately have a few places where the code got inflated by at least
> the factor of 3 because now some code uses the ISO initializers for
> everything - for no good reason.

What if someone will change struct resource in the future?

Gr{oetje,eeting}s,

                                                Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                                            -- Linus Torvalds


<Prev in Thread] Current Thread [Next in Thread>