linux-mips
[Top] [All Lists]

Re: [patch] cp0.config access macros

To: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Subject: Re: [patch] cp0.config access macros
From: Ralf Baechle <ralf@linux-mips.org>
Date: Tue, 15 Apr 2003 16:35:58 +0200
Cc: linux-mips@linux-mips.org
In-reply-to: <Pine.GSO.3.96.1030415155224.13254F-100000@delta.ds2.pg.gda.pl>; from macro@ds2.pg.gda.pl on Tue, Apr 15, 2003 at 04:07:18PM +0200
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <Pine.GSO.3.96.1030415155224.13254F-100000@delta.ds2.pg.gda.pl>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.2.5.1i
On Tue, Apr 15, 2003 at 04:07:18PM +0200, Maciej W. Rozycki wrote:

>  Cryptic cp0.config accesses using hardcoded numbers are scattered through
> the sources.  I propose adding a few definitions to improve readability
> and ease grepping the sources.  This is for solely for cp0.config now -- I
> fixed all references I had docs handy for.  The next step should probably
> be cp0.config1.
> 
>  Beside that, the following patch fixes cache size units to be kilobytes
> instead of kilobits and fixes the R4000SC erratum #5 trigger. 
> 
>  OK?

Yep.

(I'm not sure if in case of the IC, IB, DC and DB bits this is not adding
some confusion - the same bits with slightly different meaning or position
exist in various processors so we may want some distinguishable names
eventually)

  Ralf

<Prev in Thread] Current Thread [Next in Thread>