linux-mips
[Top] [All Lists]

Re: Patch to include/asm-mips/processor.h

To: Hartvig Ekner <hartvig@ekner.info>
Subject: Re: Patch to include/asm-mips/processor.h
From: Ralf Baechle <ralf@linux-mips.org>
Date: Wed, 9 Apr 2003 03:16:31 +0200
Cc: Linux MIPS mailing list <linux-mips@linux-mips.org>
In-reply-to: <3E917AA1.13694D03@ekner.info>; from hartvig@ekner.info on Mon, Apr 07, 2003 at 03:18:25PM +0200
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <3E917AA1.13694D03@ekner.info>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.2.5.1i
On Mon, Apr 07, 2003 at 03:18:25PM +0200, Hartvig Ekner wrote:

> I have no idea whether what I did was correct, but at least it is no less 
> incorrect than the code currently
> in there, which coredumps now for some reason (I wonder why it never crashed 
> before). The test-bit macro
> expects a bit-number, and not a mask which it is given in the current code.
> 
> So while fixing this, I also used the normal cpu_data macro for the 
> cpu_has_watch() macro, instead of
> looking at CPU(0).

The plan was to make the options field a bitfield like on i386 but I
changed my mind because we still have plenty of unused bits left.  I've
put a fix into CVS.  The patch also replaces all the manual bit tests
of the options field with feature test macros.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>