| To: | "Hartvig Ekner" <hartvig@ekner.info> |
|---|---|
| Subject: | Re: Patch to include/asm-mips/processor.h |
| From: | "Kip Walker" <kwalker@broadcom.com> |
| Date: | Mon, 07 Apr 2003 15:07:29 -0700 |
| Cc: | "Linux MIPS mailing list" <linux-mips@linux-mips.org> |
| Organization: | Broadcom Corp. BPBU |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <3E917AA1.13694D03@ekner.info> |
| Sender: | linux-mips-bounce@linux-mips.org |
Hartvig Ekner wrote: > > I have no idea whether what I did was correct, but at least it is no less > incorrect than the code currently > in there, which coredumps now for some reason (I wonder why it never crashed > before). The test-bit macro > expects a bit-number, and not a mask which it is given in the current code. > > So while fixing this, I also used the normal cpu_data macro for the > cpu_has_watch() macro, instead of > looking at CPU(0). > > /Hartvig The second argument to test_bit ought to have been an address, not a value. Why didn't this crash before? I just ran into it too... Kip |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: 64 to 32 bit jr, Maciej W. Rozycki |
|---|---|
| Next by Date: | Aliasing in pgtable-bits.h (CONFIG_64BIT_PHYS_ADDR), Hartvig Ekner |
| Previous by Thread: | Patch to include/asm-mips/processor.h, Hartvig Ekner |
| Next by Thread: | Re: Patch to include/asm-mips/processor.h, Ralf Baechle |
| Indexes: | [Date] [Thread] [Top] [All Lists] |