I reported this bug last May. Apparently it is still not
taken up-stream. Ralf, why don't we fix it here and push
it up from you?
BTW, this bug actually has effect on real-time performance under
preemptible kernel. It can delay the execution of the highest
priority real-time process from execution up to 1 jiffy.
Jun
On Thu, Mar 06, 2003 at 05:01:24PM -0800, Kip Walker wrote:
>
> The comparisons of oldest_idle below trigger compiler warnings and
> should probably be safely type-cast:
>
> Kip
>
> Index: kernel/sched.c
> ===================================================================
> RCS file: /home/cvs/linux/kernel/sched.c,v
> retrieving revision 1.64.2.6
> diff -u -r1.64.2.6 sched.c
> --- kernel/sched.c 25 Feb 2003 22:03:13 -0000 1.64.2.6
> +++ kernel/sched.c 7 Mar 2003 00:57:35 -0000
> @@ -282,7 +282,7 @@
> target_tsk = tsk;
> }
> } else {
> - if (oldest_idle == -1ULL) {
> + if (oldest_idle == (cycles_t) -1) {
> int prio = preemption_goodness(tsk, p,
> cpu);
>
> if (prio > max_prio) {
> @@ -294,7 +294,7 @@
> }
> tsk = target_tsk;
> if (tsk) {
> - if (oldest_idle != -1ULL) {
> + if (oldest_idle != (cycles_t) -1) {
> best_cpu = tsk->processor;
> goto send_now_idle;
> }
>
>
|