linux-mips
[Top] [All Lists]

Re: [PATCH] add CONFIG_DEBUG_INFO

To: linux-mips@linux-mips.org
Subject: Re: [PATCH] add CONFIG_DEBUG_INFO
From: "Kip Walker" <kwalker@broadcom.com>
Date: Thu, 06 Mar 2003 08:47:16 -0800
Cc: "Ralf Baechle" <ralf@linux-mips.org>
Organization: Broadcom Corp. BPBU
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20030220113404.E7466@mvista.com> <3E63B047.D3BA2A2C@broadcom.com> <86d6l8fcvv.fsf@trasno.mitica>
Sender: linux-mips-bounce@linux-mips.org
Any more comments on this topic?  Here's a patch that incorporates
Juan's suggestion.  I'm content to do away with the multiple-dependence
syntax in the Makefiles...  having KGDB on defines "CONFIG_DEBUG_INFO",
otherwise you can explicitly turn it on.  If no one objects, I'll do the
same for 2.5.

Kip
Index: arch/mips/config-shared.in
===================================================================
RCS file: /home/cvs/linux/arch/mips/Attic/config-shared.in,v
retrieving revision 1.1.2.48
diff -u -r1.1.2.48 config-shared.in
--- arch/mips/config-shared.in  26 Feb 2003 21:14:23 -0000      1.1.2.48
+++ arch/mips/config-shared.in  6 Mar 2003 16:43:59 -0000
@@ -977,6 +977,11 @@
 bool 'Are you using a crosscompiler' CONFIG_CROSSCOMPILE
 bool 'Enable run-time debugging' CONFIG_RUNTIME_DEBUG
 bool 'Remote GDB kernel debugging' CONFIG_KGDB
+if [ "$CONFIG_KGDB" = "y" ]; then
+   define_bool CONFIG_DEBUG_INFO y
+else
+   bool 'Debugging symbols' CONFIG_DEBUG_INFO
+fi
 dep_bool '  Console output to GDB' CONFIG_GDB_CONSOLE $CONFIG_KGDB
 if [ "$CONFIG_SIBYTE_SB1xxx_SOC" = "y" ]; then
    bool 'Compile for Corelis Debugger' CONFIG_SB1XXX_CORELIS
Index: arch/mips/Makefile
===================================================================
RCS file: /home/cvs/linux/arch/mips/Makefile,v
retrieving revision 1.78.2.23
diff -u -r1.78.2.23 Makefile
--- arch/mips/Makefile  26 Feb 2003 21:14:23 -0000      1.78.2.23
+++ arch/mips/Makefile  6 Mar 2003 16:43:59 -0000
@@ -41,11 +41,11 @@
 LINKFLAGS      += -G 0 -static # -N
 MODFLAGS       += -mlong-calls
 
-ifdef CONFIG_KGDB
+ifdef CONFIG_DEBUG_INFO
 GCCFLAGS       += -g
+endif
 ifdef CONFIG_SB1XXX_CORELIS
 GCCFLAGS       += -mno-sched-prolog -fno-omit-frame-pointer
-endif
 endif
 
 check_gcc = $(shell if $(CC) $(1) -S -o /dev/null -xc /dev/null > /dev/null 
2>&1; then echo "$(1)"; else echo "$(2)"; fi)
Index: arch/mips64/Makefile
===================================================================
RCS file: /home/cvs/linux/arch/mips64/Makefile,v
retrieving revision 1.22.2.27
diff -u -r1.22.2.27 Makefile
--- arch/mips64/Makefile        26 Feb 2003 21:14:24 -0000      1.22.2.27
+++ arch/mips64/Makefile        6 Mar 2003 16:43:59 -0000
@@ -39,11 +39,11 @@
 LINKFLAGS      += -G 0 -static # -N
 MODFLAGS       += -mlong-calls
 
-ifdef CONFIG_KGDB
+ifdef CONFIG_DEBUG_INFO
 GCCFLAGS       += -g
+endif
 ifdef CONFIG_SB1XXX_CORELIS
 GCCFLAGS       += -mno-sched-prolog -fno-omit-frame-pointer
-endif
 endif
 
 check_gcc = $(shell if $(CC) $(1) -S -o /dev/null -xc /dev/null > /dev/null 
2>&1; then echo "$(1)"; else echo "$(2)"; fi)
<Prev in Thread] Current Thread [Next in Thread>