linux-mips
[Top] [All Lists]

Re: [PATCH] allow CROSS_COMPILE override

To: Brian Murphy <brian@murphy.dk>
Subject: Re: [PATCH] allow CROSS_COMPILE override
From: Jun Sun <jsun@mvista.com>
Date: Thu, 20 Feb 2003 16:08:10 -0800
Cc: linux-mips@linux-mips.org, jsun@mvista.com
In-reply-to: <3E5550BA.4050107@murphy.dk>; from brian@murphy.dk on Thu, Feb 20, 2003 at 11:03:38PM +0100
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20030220124703.H7466@mvista.com> <3E55455A.8080403@murphy.dk> <20030220132300.I7466@mvista.com> <3E5550BA.4050107@murphy.dk>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.2.5i
On Thu, Feb 20, 2003 at 11:03:38PM +0100, Brian Murphy wrote:
> Jun Sun wrote:
> 
> >Is this allowed?  Can't find any such usage in kernel other
> >than the worrisome comment below:
> >
> >arch/arm/Makefile:# Grr, ?= doesn't work as all the other assignment 
> >operators do.  Make bug?
> >
> >
> >  
> >
> The arm code does this:
> 
> # Only set INCDIR if its not already defined above
> # Grr, ?= doesn't work as all the other assignment operators do.  Make bug?
> ifeq ($(origin INCDIR), undefined)
> INCDIR          := $(MACHINE)
> endif
> 
> where the make docs say:
> 
> INCDIR ?= $(MACHINE)
> 
> is the same as
> 
> ifeq ($(origin INCDIR), undefined)
> INCDIR          = $(MACHINE)
> endif
> 
> which means INCDIR will reflect changes to MACHINE.
> The := form sets INCDIR once and for all. What do you want?

':=' is fine, as long as "?=" is deemed appropriate for kernel and hackers.

Jun

<Prev in Thread] Current Thread [Next in Thread>