linux-mips
[Top] [All Lists]

[patch] bogus ramdisk sanity check on ip27

To: Linux-MIPS <linux-mips@linux-mips.org>
Subject: [patch] bogus ramdisk sanity check on ip27
From: Andrew Clausen <clausen@melbourne.sgi.com>
Date: Thu, 20 Feb 2003 11:38:39 +1100
Cc: ralf@linux-mips.org
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.4i
Hi all,

There is currently a check that the ramdisk image resides at a sane
memory address, below "max_pfn".  However, max_pfn isn't initialized
(and apparently isn't relevant) for ip27.  The only assignments to
max_pfn lie inside #ifndef CONFIG_SGI_IP27.

Therefore, this test is bogus, so here's a patch to
#ifndef CONFIG_SGI_IP27 it.

This patch applies cleanly on 2.4.x and 2.5.x (at a different offset).

Cheers,
Andrew

diff -u -r1.31.2.25 setup.c
--- arch/mips64/kernel/setup.c  22 Jan 2003 05:11:38 -0000      1.31.2.25
+++ arch/mips64/kernel/setup.c  20 Feb 2003 00:05:41 -0000
@@ -358,6 +358,8 @@
                printk("Initial ramdisk at: 0x%p (%lu bytes)\n",
                       (void *)initrd_start,
                       initrd_size);
+/* FIXME: is this right? */
+#ifndef CONFIG_SGI_IP27
                if (CPHYSADDR(initrd_end) > PFN_PHYS(max_pfn)) {
                        printk("initrd extends beyond end of memory "
                               "(0x%p > 0x%p)\ndisabling initrd\n",
@@ -365,6 +367,7 @@
                               (void *)PFN_PHYS(max_pfn));
                        initrd_start = 0;
                }
+#endif /* !CONFIG_SGI_IP27 */
        }
 #endif
 }



<Prev in Thread] Current Thread [Next in Thread>