linux-mips
[Top] [All Lists]

Re: [PATCH][2.5][4/14] smp_call_function_on_cpu - MIPS

To: Zwane Mwaikambo <zwane@zwane.ca>
Subject: Re: [PATCH][2.5][4/14] smp_call_function_on_cpu - MIPS
From: Justin Carlson <justinca@cs.cmu.edu>
Date: 14 Feb 2003 12:41:06 -0500
Cc: linux-kernel@vger.kernel.org, linux-mips@linux-mips.org
In-reply-to: <Pine.LNX.4.50.0302140356050.3518-100000@montezuma.mastecende.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <Pine.LNX.4.50.0302140356050.3518-100000@montezuma.mastecende.com>
Sender: linux-mips-bounce@linux-mips.org
On Fri, 2003-02-14 at 04:33, Zwane Mwaikambo wrote:
> +}
> +
> +int smp_call_function (void (*func) (void *info), void *info, int retry, int 
> wait)
> +{
> +     return smp_call_function_on_cpu(func, info, wait, cpu_online_map);
>  }

IIRC, the semantics of smp_call_function() are to call the function on
all other cpus.  So shouldn't this be

        return smp_call_function_on_cpu(func, info, wait, cpu_online_map & 
~(1<<smp_processor_id()));

?

Also, maybe you were planning to do this in a future patch, but
shouldn't smp_call_function() be moved to non-arch-specific code, given
this change?

-Justin



<Prev in Thread] Current Thread [Next in Thread>