linux-mips
[Top] [All Lists]

Re: [patch] ip27's _flush_cache_all uninitialized

To: Andrew Clausen <clausen@melbourne.sgi.com>
Subject: Re: [patch] ip27's _flush_cache_all uninitialized
From: Ralf Baechle <ralf@linux-mips.org>
Date: Fri, 14 Feb 2003 02:58:35 +0100
Cc: Linux-MIPS <linux-mips@linux-mips.org>, mg@sgi.com, gnb@sgi.com
In-reply-to: <20030213060017.GL8408@pureza.melbourne.sgi.com>; from clausen@melbourne.sgi.com on Thu, Feb 13, 2003 at 05:00:17PM +1100
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20030213060017.GL8408@pureza.melbourne.sgi.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.2.5.1i
On Thu, Feb 13, 2003 at 05:00:17PM +1100, Andrew Clausen wrote:

> _flush_cache_all() and ___flush_cache_all() were uninitialized
> (i.e. NULL).  Someone probably assumed (incorrectly) that this
> was ok, since flush_cache_all() doesn't use _flush_cache_all()
> (or so they thought...).
> 
> End result: anything that called flush_cache_all() (a macro)
> tried to call a function at 0x0, and died.  This includes vmalloc().
> 
> I'm not sure what the best solution is, but this makes things work:

And is guaranateed to crawl.  flush_cache_all() is a no-op for the R10k.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>